Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 18 Nov 2011 21:42:51 +0000 (UTC)
From: "Todd Lipcon (Updated) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1910424866.45060.1321652571956.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1517937234.42677.1321607391928.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-2563) Some cleanup in BPOfferService
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-2563?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-2563:
------------------------------

    Attachment: hdfs-2563.txt

The previous version of the patch had an issue where the block pool wasn't getting registered in blockPoolManager early enough. New rev cleans this up, and the tests that failed seem to pass now locally.

Also fixed a few of the log messages which were including the nnAddr twice (once as part of toString() and once in the log message)
                
> Some cleanup in BPOfferService
> ------------------------------
>
>                 Key: HDFS-2563
>                 URL: https://issues.apache.org/jira/browse/HDFS-2563
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.24.0, 0.23.1
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2563.txt, hdfs-2563.txt
>
>
> BPOfferService is currently rather difficult to follow and not really commented. This JIRA is to clean up the code a bit, add javadocs/comments where necessary, and improve the formatting of the log messages.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira