Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 97EE77E14 for ; Fri, 18 Nov 2011 01:42:16 +0000 (UTC) Received: (qmail 45305 invoked by uid 500); 18 Nov 2011 01:42:16 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 45262 invoked by uid 500); 18 Nov 2011 01:42:16 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 45131 invoked by uid 99); 18 Nov 2011 01:42:16 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Nov 2011 01:42:16 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Fri, 18 Nov 2011 01:42:13 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8D8FA8CDB6 for ; Fri, 18 Nov 2011 01:41:52 +0000 (UTC) Date: Fri, 18 Nov 2011 01:41:52 +0000 (UTC) From: "Eli Collins (Commented) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1636202825.41659.1321580512581.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <61493668.41237.1321577337249.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2562) Refactor DN configuration variables out of DataNode class MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-2562?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13152581#comment-13152581 ] Eli Collins commented on HDFS-2562: ----------------------------------- Looks good. +1 pending hudson > Refactor DN configuration variables out of DataNode class > --------------------------------------------------------- > > Key: HDFS-2562 > URL: https://issues.apache.org/jira/browse/HDFS-2562 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node > Affects Versions: 0.24.0, 0.23.1 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Attachments: hdfs-2562.txt > > > Right now there are many member variables in DataNode.java which are just read from configuration when the DN is started. Similar to what we did with DFSClient, we should refactor them into a new DNConf class which can be passed around - the motivation is to remove the many references we have throughout the code that read package-protected members of DataNode and reduce the number of members in DataNode itself. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira