Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 21 Nov 2011 19:28:51 +0000 (UTC)
From: "Todd Lipcon (Updated) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1496857564.52318.1321903731654.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1410151931.46259.1321668771931.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-2566) Move BPOfferService to be a non-inner
 class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Todd Lipcon updated HDFS-2566:
------------------------------

       Resolution: Fixed
    Fix Version/s: 0.23.1
                   0.24.0
     Hadoop Flags: Reviewed
           Status: Resolved  (was: Patch Available)

Committed to 23 and trunk (the reason to put this in 23 is so future backports and the HA merge are easier)
                
> Move BPOfferService to be a non-inner class
> -------------------------------------------
>
>                 Key: HDFS-2566
>                 URL: https://issues.apache.org/jira/browse/HDFS-2566
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.1
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>             Fix For: 0.24.0, 0.23.1
>
>         Attachments: hdfs-2566-branch-0.23.txt, hdfs-2566.txt, hdfs-2566.txt, hdfs-2566.txt
>
>
> Rounding out the cleanup of BPOfferService, it would be good to move it to its own file, so it's no longer an inner class. DataNode.java is really large and hard to navigate. BPOfferService itself is ~700 lines, so seems like a large enough unit to merit its own file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira