Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id DC00390FC for ; Thu, 3 Nov 2011 01:21:55 +0000 (UTC) Received: (qmail 71601 invoked by uid 500); 3 Nov 2011 01:21:55 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 71556 invoked by uid 500); 3 Nov 2011 01:21:55 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 71542 invoked by uid 99); 3 Nov 2011 01:21:55 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 01:21:55 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Thu, 03 Nov 2011 01:21:53 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 6976132FBC1 for ; Thu, 3 Nov 2011 01:21:32 +0000 (UTC) Date: Thu, 3 Nov 2011 01:21:32 +0000 (UTC) From: "Hudson (Commented) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1468298269.53911.1320283292433.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <1155177900.52561.1320266732516.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2533) Remove needless synchronization on FSDataSet.getBlockFile MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142758#comment-13142758 ] Hudson commented on HDFS-2533: ------------------------------ Integrated in Hadoop-Common-0.23-Commit #139 (See [https://builds.apache.org/job/Hadoop-Common-0.23-Commit/139/]) HDFS-2533. Remove needless synchronization on some FSDataSet methods. Contributed by Todd Lipcon. todd : http://svn.apache.org/viewcvs.cgi/?root=Apache-SVN&view=rev&rev=1196901 Files : * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/CHANGES.txt * /hadoop/common/branches/branch-0.23/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/datanode/FSDataset.java > Remove needless synchronization on FSDataSet.getBlockFile > --------------------------------------------------------- > > Key: HDFS-2533 > URL: https://issues.apache.org/jira/browse/HDFS-2533 > Project: Hadoop HDFS > Issue Type: Improvement > Components: data-node, performance > Affects Versions: 0.23.0 > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Priority: Minor > Fix For: 0.24.0, 0.23.1 > > Attachments: hdfs-2533.txt, hdfs-2533.txt > > > HDFS-1148 discusses lock contention issues in FSDataset. It provides a more comprehensive fix, converting it all to RWLocks, etc. This JIRA is for one very specific fix which gives a decent performance improvement for TestParallelRead: getBlockFile() currently holds the lock which is completely unnecessary. -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira