Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 008049BCC for ; Sun, 20 Nov 2011 20:42:16 +0000 (UTC) Received: (qmail 21393 invoked by uid 500); 20 Nov 2011 20:42:15 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 21366 invoked by uid 500); 20 Nov 2011 20:42:15 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 21358 invoked by uid 99); 20 Nov 2011 20:42:15 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 Nov 2011 20:42:15 +0000 X-ASF-Spam-Status: No, hits=-2001.2 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Sun, 20 Nov 2011 20:42:13 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 8957792ED4 for ; Sun, 20 Nov 2011 20:41:52 +0000 (UTC) Date: Sun, 20 Nov 2011 20:41:52 +0000 (UTC) From: "Konstantin Boudnik (Commented) (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1340323069.49428.1321821712563.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <629633528.49390.1321819311756.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2573) TestFiDataXceiverServer is failing, not testing OOME MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153867#comment-13153867 ] Konstantin Boudnik commented on HDFS-2573: ------------------------------------------ I think there's a couple of approaches here: - overwrite {{datanode.threadGroup#uncaughtException}} method - inject a bit more code {{DataXceiver}} so a listener can be registered and notified when OOME is thrown in {{run()}}. Both are doable, the latter is a way simpler. > TestFiDataXceiverServer is failing, not testing OOME > ---------------------------------------------------- > > Key: HDFS-2573 > URL: https://issues.apache.org/jira/browse/HDFS-2573 > Project: Hadoop HDFS > Issue Type: Bug > Components: data-node, test > Affects Versions: 0.22.0 > Reporter: Konstantin Shvachko > Fix For: 0.22.0 > > > TestFiDataXceiverServer is failing occasionally. It turns out also that the test is not testing the desired condition, because OOME is not caught in DataXceiverServer.run() -- This message is automatically generated by JIRA. If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa For more information on JIRA, see: http://www.atlassian.com/software/jira