hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2547) ReplicationTargetChooser has incorrect block placement comments
Date Fri, 11 Nov 2011 13:14:51 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2547?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13148467#comment-13148467
] 

Hadoop QA commented on HDFS-2547:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12503369/HDFS-2547.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    -1 patch.  The patch command could not apply the patch.

Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1553//console

This message is automatically generated.
                
> ReplicationTargetChooser has incorrect block placement comments
> ---------------------------------------------------------------
>
>                 Key: HDFS-2547
>                 URL: https://issues.apache.org/jira/browse/HDFS-2547
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.20.1
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.20.206.0
>
>         Attachments: HDFS-2547.patch, HDFS-2547.patch
>
>
> {code}
> /** The class is responsible for choosing the desired number of targets
>  * for placing block replicas.
>  * The replica placement strategy is that if the writer is on a datanode,
>  * the 1st replica is placed on the local machine, 
>  * otherwise a random datanode. The 2nd replica is placed on a datanode
>  * that is on a different rack. The 3rd replica is placed on a datanode
>  * which is on the same rack as the **first replca**.
>  */
> {code}
> That should read "second replica". The test cases confirm that this is the behavior,
as well as the docs.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message