hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Todd Lipcon (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2566) Move BPOfferService to be a non-inner class
Date Mon, 21 Nov 2011 19:26:52 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2566?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Todd Lipcon updated HDFS-2566:
------------------------------

    Attachment: hdfs-2566-branch-0.23.txt

Here's the patch for 0.23 (a little different since trunk has the "Deletion reports" feature).
I inspected the diff between the two patches for trunk vs 23 and made sure there's nothing
else differing. Also checked that the "-" lines from DataNode.java diff cleanly against the
"+" lines in BPOfferService.java.
                
> Move BPOfferService to be a non-inner class
> -------------------------------------------
>
>                 Key: HDFS-2566
>                 URL: https://issues.apache.org/jira/browse/HDFS-2566
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.1
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-2566-branch-0.23.txt, hdfs-2566.txt, hdfs-2566.txt, hdfs-2566.txt
>
>
> Rounding out the cleanup of BPOfferService, it would be good to move it to its own file,
so it's no longer an inner class. DataNode.java is really large and hard to navigate. BPOfferService
itself is ~700 lines, so seems like a large enough unit to merit its own file.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message