hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2246) Shortcut a local client reads to a Datanodes files directly
Date Thu, 10 Nov 2011 02:41:52 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2246?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13147459#comment-13147459
] 

Tsz Wo (Nicholas), SZE commented on HDFS-2246:
----------------------------------------------

- In BlockReaderLocal,
-* change newBlockReader(..) to package private
-* remove checkShortCircuitRead(..) since DFSClient has checked it.
-* remove initLocalDatanodeInfo(..); check null and init in getLocalDatanodeInfo(..)
-* add a local variable for LocalDatanodeInfo in getBlockPathInfo(..) and  newBlockReader(..)
so that we don't have to lookup the map multiple times.
-* Both pairs createDatanodeProxy/resetDatanodeProxy and getProxy/setProxy are synchronized.
 So one of the synchronizations is redundant.  I suggest move createDatanodeProxy/resetDatanodeProxy
to LocalDatanodeInfo and sync inside LocalDatanodeInfo.

- change DFSClient.getLocalBlockReader(..) to private

- In DataNode,
-* check DFS_CLIENT_READ_SHORTCIRCUIT when initializing userWithLocalPathAccess.  What should
happen if DFS_CLIENT_READ_SHORTCIRCUIT is false but DFS_BLOCK_LOCAL_PATH_ACCESS_USER_KEY is
set to some user?

- use org.junit.Assert in TestShortCircuitLocalRead
                
> Shortcut a local client reads to a Datanodes files directly
> -----------------------------------------------------------
>
>                 Key: HDFS-2246
>                 URL: https://issues.apache.org/jira/browse/HDFS-2246
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>         Attachments: 0001-HDFS-347.-Local-reads.patch, HDFS-2246-branch-0.20-security-205.patch,
HDFS-2246-branch-0.20-security-205.patch, HDFS-2246-branch-0.20-security-205.patch, HDFS-2246-branch-0.20-security.3.patch,
HDFS-2246-branch-0.20-security.no-softref.patch, HDFS-2246-branch-0.20-security.patch, HDFS-2246.20s.1.patch,
HDFS-2246.20s.2.txt, HDFS-2246.20s.3.txt, HDFS-2246.20s.4.txt, HDFS-2246.20s.patch, localReadShortcut20-security.2patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message