hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2308) NamenodeProtocol.endCheckpoint is vestigial and can be removed
Date Tue, 01 Nov 2011 04:20:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140904#comment-13140904
] 

Hadoop QA commented on HDFS-2308:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501719/hdfs-2308-2.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.TestAbandonBlock

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1511//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1511//console

This message is automatically generated.
                
> NamenodeProtocol.endCheckpoint is vestigial and can be removed
> --------------------------------------------------------------
>
>                 Key: HDFS-2308
>                 URL: https://issues.apache.org/jira/browse/HDFS-2308
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Eli Collins
>         Attachments: hdfs-2308-1.patch, hdfs-2308-1.patch, hdfs-2308-2.patch
>
>
> Post HDFS-1073, this method is now a no-op. All it does currently is validate the CheckpointSignature
provided, but does nothing to mutate NN state.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message