hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2559) Clean up Storage/StorageInfo classes after federation
Date Thu, 17 Nov 2011 05:04:51 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2559?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13151807#comment-13151807

Hadoop QA commented on HDFS-2559:

-1 overall.  Here are the results of testing the latest attachment 
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 30 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit

    -1 core tests.  The patch failed these unit tests:

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1564//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1564//console

This message is automatically generated.
> Clean up Storage/StorageInfo classes after federation
> -----------------------------------------------------
>                 Key: HDFS-2559
>                 URL: https://issues.apache.org/jira/browse/HDFS-2559
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.1
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>         Attachments: hdfs-2559.txt
> After federation, there are many different identifiers floating around in a cluster:
cluster ID, namespace ID, block pool ID, plus the versioning identifiers cTime and layoutVersion.
Some of these are cluster-wide, whereas others may be different within a DN as it talks to
different NNs (see the federation design doc for more info). However, the current class heirarchy
in trunk has DataStorage (the DN-wide storage class) inherit from Storage which inherits from
StorageInfo, which contains a namespaceID. Thus, DataStorage has this unused member which
confuses things.
> This JIRA is to split up StorageInfo into separate classes/interfaces so that only the
necessary identifiers are used by each piece of the DN.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message