hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Konstantin Boudnik (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2573) TestFiDataXceiverServer is failing, not testing OOME
Date Sun, 20 Nov 2011 20:29:52 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2573?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13153864#comment-13153864
] 

Konstantin Boudnik commented on HDFS-2573:
------------------------------------------

I agree with your analysis Konstantin: test works as expected however OOME thrown in threadB
isn't getting caught in threadA starting the former.
I have removed all AOP code from the test and manually added OOME throwing to DataXceiver#run
method - and see exactly the same behavior.

The only modification I can think of in this case is to throw OOME before new DataXceiver
thread is spawned, but this defeats the purpose of the test completely. We can exclude it
for now in a hope to find a better solution later or just completely remove it. Either way
is fine with me. 
                
> TestFiDataXceiverServer is failing, not testing OOME
> ----------------------------------------------------
>
>                 Key: HDFS-2573
>                 URL: https://issues.apache.org/jira/browse/HDFS-2573
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node, test
>    Affects Versions: 0.22.0
>            Reporter: Konstantin Shvachko
>             Fix For: 0.22.0
>
>
> TestFiDataXceiverServer is failing occasionally. It turns out also that the test is not
testing the desired condition, because OOME is not caught in DataXceiverServer.run()

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message