hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2533) Remove needless synchronization on FSDataSet.getBlockFile
Date Thu, 03 Nov 2011 00:59:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2533?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13142736#comment-13142736
] 

Hadoop QA commented on HDFS-2533:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12502057/hdfs-2533.txt
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.TestFileAppend2
                  org.apache.hadoop.hdfs.TestBalancerBandwidth

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1526//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1526//console

This message is automatically generated.
                
> Remove needless synchronization on FSDataSet.getBlockFile
> ---------------------------------------------------------
>
>                 Key: HDFS-2533
>                 URL: https://issues.apache.org/jira/browse/HDFS-2533
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node, performance
>    Affects Versions: 0.23.0
>            Reporter: Todd Lipcon
>            Assignee: Todd Lipcon
>            Priority: Minor
>         Attachments: hdfs-2533.txt, hdfs-2533.txt
>
>
> HDFS-1148 discusses lock contention issues in FSDataset. It provides a more comprehensive
fix, converting it all to RWLocks, etc. This JIRA is for one very specific fix which gives
a decent performance improvement for TestParallelRead: getBlockFile() currently holds the
lock which is completely unnecessary.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message