Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Fri, 21 Oct 2011 20:04:32 +0000 (UTC)
From: "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <587762324.2936.1319227472987.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <973073316.999.1319205632408.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2485) Improve code layout and constants in
 UnderReplicatedBlocks
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13133011#comment-13133011 ] 

Tsz Wo (Nicholas), SZE commented on HDFS-2485:
----------------------------------------------

I believe the failed tests are not related to the patch.
                
> Improve code layout and constants in UnderReplicatedBlocks
> ----------------------------------------------------------
>
>                 Key: HDFS-2485
>                 URL: https://issues.apache.org/jira/browse/HDFS-2485
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Trivial
>         Attachments: HDFS-2485-improve-underreplicated.patch
>
>   Original Estimate: 0.5h
>          Time Spent: 1h
>  Remaining Estimate: 0h
>
> Before starting HDFS-2472 I want to clean up the code in UnderReplicatedBlocks slightly
> # use constants for all the string levels
> # change the {{getUnderReplicatedBlockCount()}} method so that it works even if the corrupted block list is not the last queue
> # improve the javadocs
> # add some more curly braces and spaces to follow the style guidelines better
> This is a trivial change as behaviour will not change at all. If committed it will go into trunk and 0.23 so that patches between the two versions are easy to apply

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira