Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Thu, 27 Oct 2011 06:08:32 +0000 (UTC)
From: "Hadoop QA (Commented) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1450181679.23038.1319695712314.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1604815811.17846.1318311990053.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2432) webhdfs setreplication api should
 return a 403 when called on a directory
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2432?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13136805#comment-13136805 ] 

Hadoop QA commented on HDFS-2432:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501030/h2432_20111026.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 8 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.TestFileAppend2
                  org.apache.hadoop.hdfs.TestBalancerBandwidth
                  org.apache.hadoop.hdfs.TestDistributedFileSystem

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1471//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1471//console

This message is automatically generated.
                
> webhdfs setreplication api should return a 403 when called on a directory
> -------------------------------------------------------------------------
>
>                 Key: HDFS-2432
>                 URL: https://issues.apache.org/jira/browse/HDFS-2432
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>    Affects Versions: 0.20.205.0
>            Reporter: Arpit Gupta
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h2432_20111026.patch, h2432_20111026_0.20s.patch
>
>
> Currently the set replication api on a directory leads to a 200.
> Request URI http://NN:50070/webhdfs/tmp/webhdfs_data/dir_replication_tests?op=SETREPLICATION&replication=5
> Request Method: PUT
> Status Line: HTTP/1.1 200 OK
> Response Content: {"boolean":false}
> Since we can determine that this call did not succeed (boolean=false) we should rather just return a 403

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira