Return-Path: 
 <hdfs-issues-return-28118-apmail-hadoop-hdfs-issues-archive=hadoop.apache.org@hadoop.apache.org>
X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org
Received: from mail.apache.org (hermes.apache.org [140.211.11.3])
	by minotaur.apache.org (Postfix) with SMTP id 8E32D9979
	for <apmail-hadoop-hdfs-issues-archive@minotaur.apache.org>;
 Mon, 31 Oct 2011 21:47:53 +0000 (UTC)
Received: (qmail 9005 invoked by uid 500); 31 Oct 2011 21:47:53 -0000
Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org
Received: (qmail 8981 invoked by uid 500); 31 Oct 2011 21:47:53 -0000
Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
List-Help: <mailto:hdfs-issues-help@hadoop.apache.org>
List-Unsubscribe: <mailto:hdfs-issues-unsubscribe@hadoop.apache.org>
List-Post: <mailto:hdfs-issues@hadoop.apache.org>
List-Id: <hdfs-issues.hadoop.apache.org>
Reply-To: hdfs-issues@hadoop.apache.org
Delivered-To: mailing list hdfs-issues@hadoop.apache.org
Received: (qmail 8973 invoked by uid 99); 31 Oct 2011 21:47:53 -0000
Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2011 21:47:53 +0000
X-ASF-Spam-Status: No, hits=-2001.2 required=5.0
	tests=ALL_TRUSTED,RP_MATCHES_RCVD
X-Spam-Check-By: apache.org
Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116)
    by apache.org (qpsmtpd/0.29) with ESMTP; Mon, 31 Oct 2011 21:47:52 +0000
Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116])
	by hel.zones.apache.org (Postfix) with ESMTP id 519FD32B79A
	for <hdfs-issues@hadoop.apache.org>; Mon, 31 Oct 2011 21:47:32 +0000 (UTC)
Date: Mon, 31 Oct 2011 21:47:32 +0000 (UTC)
From: "Uma Maheswara Rao G (Updated) (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1154639565.42842.1320097652335.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <887330740.12957.1307751540099.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit
X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394


     [ https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uma Maheswara Rao G updated HDFS-2065:
--------------------------------------

    Attachment: HDFS-2065.patch

Updated patch for trunk!
Handled null checks, because blockManager#createLocatedBlocks can return null when node.getBlocks return null. I did not find any direct scenario to replicate it. Added the same test cases for trunk.


Thanks
Uma
                
> Fix NPE in DFSClient.getFileChecksum
> ------------------------------------
>
>                 Key: HDFS-2065
>                 URL: https://issues.apache.org/jira/browse/HDFS-2065
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Bharath Mundlapudi
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, HDFS-2065-20.205Security.patch, HDFS-2065.patch
>
>
> The following code can throw NPE if callGetBlockLocations returns null.
> If server returns null 
> {code}
>     List<LocatedBlock> locatedblocks
>         = callGetBlockLocations(namenode, src, 0, Long.MAX_VALUE).getLocatedBlocks();
> {code}
> The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira