hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2231) Configuration changes for HA namenode
Date Wed, 05 Oct 2011 17:37:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2231?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13121191#comment-13121191

Aaron T. Myers commented on HDFS-2231:

Hey Suresh, patch looks pretty good to me. Two small comments:

# Why remove {{DFSUtil.getNameServiceIdKey}}, when you could have just implemented this method
in terms of {{DFSUtil.addSuffixes}}? Doing so will save you having to change all the references
to {{DFSUtil.getNameServiceIdKey}} that are presently littered throughout the code.
# Should probably remove this: "{{System.out.println("Suresh returning key " + key + "  "
+ keySuffix);}}", as not all users will know who "Suresh" is. :)
> Configuration changes for HA namenode
> -------------------------------------
>                 Key: HDFS-2231
>                 URL: https://issues.apache.org/jira/browse/HDFS-2231
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: HA branch (HDFS-1623)
>         Attachments: HDFS-2231.txt
> This jira tracks the changes required for configuring HA setup for namenodes.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message