hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Sanjay Radia (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2181) Seperate HDFS wire protocol data types
Date Tue, 04 Oct 2011 20:11:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2181?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120428#comment-13120428

Sanjay Radia commented on HDFS-2181:

Thanks for the feedback.
* Prefix. The right thing to do is to add a suffix Writable - ie BlockWritable (just like
BlockProto). As we add new types in future releases, the protocol version will NOT change
(recall the rule - add new types and new methods). This makes sense because at some point
we will remove writables from all other HDFS types. I can make that change.
* Javadoc - It took a lot of time to put it. Given that it is done I prefer to leave it in
since it will not be too bad to maintain. I did a similar thing for AbstractFileSystem and
the main motivation was that we could  hand this to a QA person to write compatibility tests.
It is kind of convenient "cursor over" when one is reading code in Eclipse.
* nits - will fix.
* arg0 arg1 - I copied the code from old types ... will fix.
* @Todd "...  GET_STATS_CAPACITY_IDX .. follow on Jira"  - Agree.

> Seperate HDFS wire protocol data types
> --------------------------------------
>                 Key: HDFS-2181
>                 URL: https://issues.apache.org/jira/browse/HDFS-2181
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: separateDataType1.patch, separateDataType10.patch, separateDataType11.patch,
separateDataType12.patch, separateDataType13.patch, separateDataType14.patch, separateDataType16.patch,
separateDataType2.patch, separateDataType6.patch, separateDataType7.patch, separateDataType8.patch,

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message