hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2485) Improve code layout and constants in UnderReplicatedBlocks
Date Fri, 21 Oct 2011 19:52:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2485?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132998#comment-13132998

Tsz Wo (Nicholas), SZE commented on HDFS-2485:

TestUnderReplicatedBlockQueues does not have license header.  Otherwise, the patch looks good.
> Improve code layout and constants in UnderReplicatedBlocks
> ----------------------------------------------------------
>                 Key: HDFS-2485
>                 URL: https://issues.apache.org/jira/browse/HDFS-2485
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Steve Loughran
>            Assignee: Steve Loughran
>            Priority: Trivial
>         Attachments: HDFS-2485-improve-underreplicated.patch
>   Original Estimate: 0.5h
>          Time Spent: 1h
>  Remaining Estimate: 0h
> Before starting HDFS-2472 I want to clean up the code in UnderReplicatedBlocks slightly
> # use constants for all the string levels
> # change the {{getUnderReplicatedBlockCount()}} method so that it works even if the corrupted
block list is not the last queue
> # improve the javadocs
> # add some more curly braces and spaces to follow the style guidelines better
> This is a trivial change as behaviour will not change at all. If committed it will go
into trunk and 0.23 so that patches between the two versions are easy to apply

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message