hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2065) Fix NPE in DFSClient.getFileChecksum
Date Mon, 31 Oct 2011 23:13:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2065?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140662#comment-13140662
] 

Hadoop QA commented on HDFS-2065:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12501686/HDFS-2065.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 7 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.TestFileAppend2
                  org.apache.hadoop.hdfs.TestBalancerBandwidth
                  org.apache.hadoop.cli.TestHDFSCLI

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1507//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1507//console

This message is automatically generated.
                
> Fix NPE in DFSClient.getFileChecksum
> ------------------------------------
>
>                 Key: HDFS-2065
>                 URL: https://issues.apache.org/jira/browse/HDFS-2065
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.23.0
>            Reporter: Bharath Mundlapudi
>            Assignee: Uma Maheswara Rao G
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2065-1.patch, HDFS-2065-20.205Security.patch, HDFS-2065-20.205Security.patch,
HDFS-2065.patch
>
>
> The following code can throw NPE if callGetBlockLocations returns null.
> If server returns null 
> {code}
>     List<LocatedBlock> locatedblocks
>         = callGetBlockLocations(namenode, src, 0, Long.MAX_VALUE).getLocatedBlocks();
> {code}
> The right fix for this is server should throw right exception.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message