hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "jiraposter@reviews.apache.org (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2301) Start/stop appropriate namenode internal services during transition to active and standby
Date Mon, 10 Oct 2011 16:13:31 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2301?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13124246#comment-13124246
] 

jiraposter@reviews.apache.org commented on HDFS-2301:
-----------------------------------------------------



bq.  On 2011-10-06 23:37:24, Todd Lipcon wrote:
bq.  > branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java,
line 28
bq.  > <https://reviews.apache.org/r/2150/diff/2/?file=48551#file48551line28>
bq.  >
bq.  >     perhaps should be abstract since it won't ever be instantiated?
bq.  >     
bq.  >     these functions are meant only for the server side, right? Otherwise they should
all take an authority, and look at configs prefixed/suffixed with that authority?
bq.  >     
bq.  >     let me jump over to HDFS-2231 and try to review that first.. having a hard time
following this.

Class has private constructor. I prefer that to abstract class. For some reason, I included
HAUtil in this patch causing lot of confusion. It belongs to 2231. So I am attaching a patch
without HAUtil changes. Also I will address rest of your HAUtil comments in 2231.


- Suresh


-----------------------------------------------------------
This is an automatically generated e-mail. To reply, visit:
https://reviews.apache.org/r/2150/#review2422
-----------------------------------------------------------


On 2011-10-06 23:25:18, Todd Lipcon wrote:
bq.  
bq.  -----------------------------------------------------------
bq.  This is an automatically generated e-mail. To reply, visit:
bq.  https://reviews.apache.org/r/2150/
bq.  -----------------------------------------------------------
bq.  
bq.  (Updated 2011-10-06 23:25:18)
bq.  
bq.  
bq.  Review request for hadoop-hdfs and Todd Lipcon.
bq.  
bq.  
bq.  Summary
bq.  -------
bq.  
bq.  Uploading Suresh's patch to reviewboard (https://issues.apache.org/jira/secure/attachment/12496953/HDFS-2301.txt
from 29/Sep/11 00:56)
bq.  
bq.  
bq.  This addresses bug HDFS-2301.
bq.      https://issues.apache.org/jira/browse/HDFS-2301
bq.  
bq.  
bq.  Diffs
bq.  -----
bq.  
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/HAUtil.java
PRE-CREATION 
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/BackupNode.java
1179521 
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/FSNamesystem.java
1179521 
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/NameNode.java
1179521 
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/ActiveState.java
1179521 
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAContext.java
PRE-CREATION 
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/HAState.java
1179521 
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/main/java/org/apache/hadoop/hdfs/server/namenode/ha/StandbyState.java
1179521 
bq.    branches/HDFS-1623/hadoop-hdfs-project/hadoop-hdfs/src/test/java/org/apache/hadoop/hdfs/TestHAUtil.java
PRE-CREATION 
bq.  
bq.  Diff: https://reviews.apache.org/r/2150/diff
bq.  
bq.  
bq.  Testing
bq.  -------
bq.  
bq.  
bq.  Thanks,
bq.  
bq.  Todd
bq.  
bq.


                
> Start/stop appropriate namenode internal services during transition to active and standby
> -----------------------------------------------------------------------------------------
>
>                 Key: HDFS-2301
>                 URL: https://issues.apache.org/jira/browse/HDFS-2301
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: HA branch (HDFS-1623)
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: HA branch (HDFS-1623)
>
>         Attachments: HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt, HDFS-2301.txt
>
>
> These changes are related to HDFS-1974 which introduced active and standby states. This
jira will address starting and stopping appropriate NN services when entering and existing
active and standby states.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message