hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2308) NamenodeProtocol.endCheckpoint is vestigial and can be removed
Date Mon, 31 Oct 2011 20:17:33 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13140520#comment-13140520

Aaron T. Myers commented on HDFS-2308:

Hey Eli, patch largely looks good. It's definitely an improvement. A few questions:

# {{FSNamesystem.endCheckpoint}} still gets the FS write lock and checks for safe mode, despite
this method not actually mutating any state. Is that still necessary?
# Might it make sense to just include the {{CheckpointSignature}} in the URL when we send
over the image via {{TransferFs.uploadImageFromStorage}}? This was the way it works in branch-0.20-security,
and I see no reason to break continue to have it broken out into a separate RPC call. This
is obviously more work, without a ton of upside except to reduce complexity. Feel free to
> NamenodeProtocol.endCheckpoint is vestigial and can be removed
> --------------------------------------------------------------
>                 Key: HDFS-2308
>                 URL: https://issues.apache.org/jira/browse/HDFS-2308
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Eli Collins
>         Attachments: hdfs-2308-1.patch, hdfs-2308-1.patch
> Post HDFS-1073, this method is now a no-op. All it does currently is validate the CheckpointSignature
provided, but does nothing to mutate NN state.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message