hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "stack (Created) (JIRA)" <j...@apache.org>
Subject [jira] [Created] (HDFS-2408) DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append
Date Thu, 06 Oct 2011 06:06:29 GMT
DFSClient#getNumCurrentReplicas is package private in 205 but public in branch-0.20-append
------------------------------------------------------------------------------------------

                 Key: HDFS-2408
                 URL: https://issues.apache.org/jira/browse/HDFS-2408
             Project: Hadoop HDFS
          Issue Type: Bug
          Components: hdfs client
    Affects Versions: 0.20.205.1
            Reporter: stack
            Assignee: stack


The below commit broke hdfs-826 for hbase in 205 rc1.  It changes the accessiblity from public
to package private on getNumCurrentReplicas and now current shipping hbase's at least cannot
get at this method.

{code}
Revision 1174483 - (view) (download) (annotate) - [select for diffs] 
Modified Fri Sep 23 01:30:18 2011 UTC (13 days, 4 hours ago) by szetszwo 
File length: 136876 byte(s) 
Diff to previous 1174479 (colored)
svn merge -c 1171137 from branch-0.20-security for HDFS-2333.
{code}

Here is diff between above change and one just previous:

http://svn.apache.org/viewvc/hadoop/common/branches/branch-0.20-security-205/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java?view=diff&r1=1174479&r2=1174483&diff_format=u

This is a critical facility for us.

It seems like making this one method public again is all thats needed.  I can make a patch
like the below:

diff --git a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
index b9cb053..39955c9 100644
--- a/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
+++ b/src/hdfs/org/apache/hadoop/hdfs/DFSClient.java
@@ -3569,7 +3569,7 @@ public class DFSClient implements FSConstants, java.io.Closeable {
      * block is not yet allocated, then this API will return 0 because there are
      * no replicas in the pipeline.
      */
-    int getNumCurrentReplicas() throws IOException {
+    public int getNumCurrentReplicas() throws IOException {
       synchronized(dataQueue) {
         if (nodes == null) {
           return blockReplication;

Can we get this into RC2?

Thanks,
St.Ack

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message