hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2294) Download of commons-daemon TAR should not be under target
Date Thu, 06 Oct 2011 20:41:29 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2294?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13122269#comment-13122269
] 

Aaron T. Myers commented on HDFS-2294:
--------------------------------------

+1, the patch looks good to me. I applied the patch, ran {{`mvn clean package -DskipTests'}},
and confirmed that commons-daemon is now downloaded to a directory outside of the {{target/}}
directory.
                
> Download of commons-daemon TAR should not be under target
> ---------------------------------------------------------
>
>                 Key: HDFS-2294
>                 URL: https://issues.apache.org/jira/browse/HDFS-2294
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: build
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Alejandro Abdelnur
>            Assignee: Alejandro Abdelnur
>             Fix For: 0.23.0, 0.24.0
>
>         Attachments: HDFS-2289.patch
>
>
> Committed HDFS-2289 downloads commons-daemon TAR in the hadoop-hdfs/target/, earlier
patches for HDFS-2289 were using hadoop-hdfs/download/ as the location for the download.
> The motivation not to use the 'target/' directory is that on every clean build the TAR
will be downloaded from Apache archives. Using a 'download' directory this happens once per
workspace.
> The patch was also adding the 'download/' directory to the .gitignore file (it should
also be svn ignored).
> Besides downloading it only once, it allows to do a clean build in disconnected mode.
> IMO, the later is a nice developer capability.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message