hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (Updated) (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2493) Remove reference to FSNamesystem in blockmanagement classes
Date Fri, 28 Oct 2011 18:11:32 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2493?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Tsz Wo (Nicholas), SZE updated HDFS-2493:
-----------------------------------------

    Attachment: h2493_20111028.patch

Hi Uma, thanks for the review.

> 1) ReplicationMonitor#computeDatanodeWork:
Can we update the below comment, it still says FSNameSystemMetrics in BlockManager. ...

Good catch.  Updated it.

> 2) There are many static imports explicitely for each Constant. Is it intensional? ...

Yes, it is intentional.  I was using Eclipse to fix the imports automatically.  I think it
is easily to let the Eclipse  managing the imports than doing manually.

Here is a new patch.

h2493_20111028.patch
                
> Remove reference to FSNamesystem in blockmanagement classes
> -----------------------------------------------------------
>
>                 Key: HDFS-2493
>                 URL: https://issues.apache.org/jira/browse/HDFS-2493
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h2493_20111022.patch, h2493_20111022b.patch, h2493_20111028.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message