hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2479) HDFS Client Data Types in Protocol Buffers
Date Wed, 26 Oct 2011 04:46:32 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2479?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13135701#comment-13135701
] 

Suresh Srinivas commented on HDFS-2479:
---------------------------------------

+1 for the patch.

Minor comments:
# There are some tab files, some extra spaces. It would also be good to have all the members
of message ordered numerically.
# UpgradeStatusReportProto is missing documentation
# I am not sure what this comment means {{  required uint64 numBytes = 3; // for historical
reasons - doesn't belong here}}
                
> HDFS Client Data Types in Protocol Buffers
> ------------------------------------------
>
>                 Key: HDFS-2479
>                 URL: https://issues.apache.org/jira/browse/HDFS-2479
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Sanjay Radia
>            Assignee: Sanjay Radia
>         Attachments: hdfs.proto, hdfs.proto, hdfs.proto, pbClientTypes1.patch, pbClientTypes2.patch,
pbClientTypes3.patch, pbClientTypes4.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message