hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2480) Separate datatypes for NamenodeProtocol
Date Thu, 20 Oct 2011 23:20:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2480?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13132187#comment-13132187

Tsz Wo (Nicholas), SZE commented on HDFS-2480:

+1 patch looks good.

Some comments (you may work on them for the next patch):

- In NamenodeWireProtocol, do we need the constants (e.g. ACT_SHUTDOWN)?

- CheckpointSignatureWritable.setBlockpoolID(..), BlockWithLocationsWritable.getBlocks(),
and all getters and setters in XxxWritable should be removed.

- We probably should have utility methods for createNamenodeWithRetry(..) and createNamenode(..).

- Remove NamenodeProtocolTranslatorR23.getProxyWithoutRetry()

- In NamenodeProtocolServerSideTranslatorR23, the error messages "Datanode Serverside ..."
should be "Namenode Serverside ...".

> Separate datatypes for NamenodeProtocol
> ---------------------------------------
>                 Key: HDFS-2480
>                 URL: https://issues.apache.org/jira/browse/HDFS-2480
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>    Affects Versions: 0.23.0, 0.24.0
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>         Attachments: HDFS-2480.txt, HDFS-2480.txt
> This jira separates for NamenodeProtocol the wire types from the types used by the client
and server, similar to HDFS-2181.

This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira


View raw message