hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2395) webhdfs api's should return a root element in the json response
Date Wed, 05 Oct 2011 05:48:34 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2395?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13120691#comment-13120691
] 

Suresh Srinivas commented on HDFS-2395:
---------------------------------------

# JsonUtil.java:
#* toJsonMap(ExtendedBlock...) javadoc says LocatedBlock.
#* minor: Instead of calling JsonUtil.method(), you could drop "JsonUtil." and just call the
method().
#* FileSystem.LOG.info XXX is needed?
#* minor: {{JsonUtil.toJsonString(Token.class.getSimpleName()}} could benefit from having
a variant JsonUtil.toJsonString(Class<?>, map) which could call getSimpleName() with
in the method.
#* minor: cast is unnecessary {{array[i] = (DatanodeInfo)toDatanodeInfo((Map<?, ?>)
objects[i]);}}
#* main method is no longer necessary

Unrelated to this patch:
# WebHdfsFileSystem#ugi hides HftpFileSystem#ugi
# NamenodeWebHdfsMethods
#* renewer not used in #generateDelegationToken
#* #put() does not use InputStream {{in}} and should not throw URISyntaxException
#* #post() does not use InputStream {{in}} and should not throw URISyntaxException
#* #get() should not throw URISyntaxException

Are these APIs going to be documented?

                
> webhdfs api's should return a root element in the json response
> ---------------------------------------------------------------
>
>                 Key: HDFS-2395
>                 URL: https://issues.apache.org/jira/browse/HDFS-2395
>             Project: Hadoop HDFS
>          Issue Type: Bug
>    Affects Versions: 0.20.205.0
>            Reporter: Arpit Gupta
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Critical
>         Attachments: h2395_20111003.patch, h2395_20111004.patch, h2395_20111004_0.20s.patch,
h2395_20111004b.patch, h2395_20111004c.patch, h2395_20111004c_0.20s.patch
>
>


--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message