Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 14 Sep 2011 04:54:08 +0000 (UTC)
From: "Uma Maheswara Rao G (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <786294599.25319.1315976048896.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <125103313.24962.1315965009151.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2330) In NNStorage.java, IOExceptions of
 stream closures  can mask root exceptions.
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2330?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104250#comment-13104250 ] 

Uma Maheswara Rao G commented on HDFS-2330:
-------------------------------------------

Test failures are not related. Since the changes are related to stream closures, not provided any special tests for this change.

> In NNStorage.java, IOExceptions of stream closures  can mask root exceptions.
> -----------------------------------------------------------------------------
>
>                 Key: HDFS-2330
>                 URL: https://issues.apache.org/jira/browse/HDFS-2330
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Uma Maheswara Rao G
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-2330.patch
>
>
> In NNStorage.java:
>   There are many stream closures in finally block. 
>   There is a chance that they can mask the root exceptions.
> So, better to follow the pattern like below:
> {code}
>   try{
>      ............
>      ............
>      stream.close();
>      stream =null;
>    }
>    finally{
>      IOUtils.cleanup(LOG, stream);
>    }
> {code}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira