hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2349) DN should log a WARN, not an INFO when it detects a corruption during block transfer
Date Mon, 19 Sep 2011 20:20:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2349?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13108106#comment-13108106
] 

Hadoop QA commented on HDFS-2349:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12495124/HDFS-2349.diff
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.TestDfsOverAvroRpc
                  org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
                  org.apache.hadoop.hdfs.server.datanode.TestReplicasMap

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1270//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1270//console

This message is automatically generated.

> DN should log a WARN, not an INFO when it detects a corruption during block transfer
> ------------------------------------------------------------------------------------
>
>                 Key: HDFS-2349
>                 URL: https://issues.apache.org/jira/browse/HDFS-2349
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: data-node
>    Affects Versions: 0.20.204.0
>            Reporter: Harsh J
>            Assignee: Harsh J
>            Priority: Trivial
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2349.diff
>
>
> Currently, in DataNode.java, we have:
> {code}
>       LOG.info("Can't replicate block " + block
>           + " because on-disk length " + onDiskLength 
>           + " is shorter than NameNode recorded length " + block.getNumBytes());
> {code}
> This log is better off as a WARN as it indicates (and also reports) a corruption.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message