hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Kelly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
Date Thu, 15 Sep 2011 08:50:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105221#comment-13105221
] 

Ivan Kelly commented on HDFS-2333:
----------------------------------

Looks good to me. +1 
Perhaps add to the DFSClient#append javadoc that null is acceptable for the 3rd and 4th parameter.

> HDFS-2284 introduced 2 findbugs warnings on trunk
> -------------------------------------------------
>
>                 Key: HDFS-2333
>                 URL: https://issues.apache.org/jira/browse/HDFS-2333
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-2333.diff, h2333_20110914.patch, h2333_20110914b.patch
>
>
> When HDFS-2284 was submitted it made DFSOutputStream public which triggered two SC_START_IN_CTOR
findbug warnings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message