hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2312) FSNamesystem header comment says it's for the DN
Date Tue, 06 Sep 2011 03:59:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2312?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13097728#comment-13097728
] 

Hadoop QA commented on HDFS-2312:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12493102/HDFS-2312.r1.diff
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:

                  org.apache.hadoop.hdfs.TestDfsOverAvroRpc
                  org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
                  org.apache.hadoop.hdfs.server.datanode.TestReplicasMap

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//artifact/trunk/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1202//console

This message is automatically generated.

> FSNamesystem header comment says it's for the DN
> ------------------------------------------------
>
>                 Key: HDFS-2312
>                 URL: https://issues.apache.org/jira/browse/HDFS-2312
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Harsh J
>            Priority: Trivial
>              Labels: newbie
>             Fix For: 0.24.0
>
>         Attachments: HDFS-2312.r1.diff
>
>
> One of the less accurate class comments I've ever seen:
> {noformat}
>  * FSNamesystem does the actual bookkeeping work for the
>  * DataNode.
> {noformat}

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message