hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2334) Add Closeable to JournalManager
Date Wed, 14 Sep 2011 16:21:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104617#comment-13104617
] 

Hadoop QA commented on HDFS-2334:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12494428/HDFS-2334.diff
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    -1 findbugs.  The patch appears to introduce 2 new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these unit tests:
                  org.apache.hadoop.hdfs.server.datanode.TestReplicasMap
                  org.apache.hadoop.hdfs.server.blockmanagement.TestHost2NodesMap
                  org.apache.hadoop.hdfs.TestDfsOverAvroRpc

    +1 contrib tests.  The patch passed contrib unit tests.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1241//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1241//artifact/trunk/hadoop-hdfs-project/patchprocess/newPatchFindbugsWarningshadoop-hdfs.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1241//console

This message is automatically generated.

> Add Closeable to JournalManager
> -------------------------------
>
>                 Key: HDFS-2334
>                 URL: https://issues.apache.org/jira/browse/HDFS-2334
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2334.diff
>
>
> A JournalManager may take hold of resources for the duration of their lifetime. This
isn't the case at the moment for FileJournalManager, but BookKeeperJournalManager will, and
it's conceivable that FileJournalManager could take a lock on a directory etc. 
> This JIRA is to add Closeable to JournalManager so that these resources can be cleaned
up when FSEditLog is closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message