hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Tsz Wo (Nicholas), SZE (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2333) HDFS-2284 introduced 2 findbugs warnings on trunk
Date Thu, 15 Sep 2011 15:38:09 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2333?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13105435#comment-13105435
] 

Tsz Wo (Nicholas), SZE commented on HDFS-2333:
----------------------------------------------

I should mention that the two SC_START_IN_CTOR findbugs warnings were due to starting a thread
in the constructors of DFSOutputStream.  The code starting a thread was there for a long time.
 In HDFS-2284, DFSOutputStream was changed from package private to public but, surprisingly,
the change triggered the findbugs warnings.  Even DFSOutputStream is package private, the
class could still be extended and the same problem could occur.  The real fix is not to starting
a thread in the constructors.

In this issue, DFSOutputStream is changed back to package private.

I have committed this.

> HDFS-2284 introduced 2 findbugs warnings on trunk
> -------------------------------------------------
>
>                 Key: HDFS-2333
>                 URL: https://issues.apache.org/jira/browse/HDFS-2333
>             Project: Hadoop HDFS
>          Issue Type: Bug
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>         Attachments: HDFS-2333.diff, h2333_20110914.patch, h2333_20110914b.patch, h2333_20110915.patch,
h2333_20110915_0.20s.patch
>
>
> When HDFS-2284 was submitted it made DFSOutputStream public which triggered two SC_START_IN_CTOR
findbug warnings.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message