hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Aaron T. Myers (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2308) NamenodeProtocol.endCheckpoint is vestigial and can be removed
Date Sun, 04 Sep 2011 05:22:11 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2308?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13096815#comment-13096815
] 

Aaron T. Myers commented on HDFS-2308:
--------------------------------------

For reference, from {{FSImage}}:

{code}
/**
 * End checkpoint.
 * <p>
 * Rename uploaded checkpoint to the new image;
 * purge old edits file;
 * rename edits.new to edits;
 * redirect edit log streams to the new edits;
 * update checkpoint time if the remote node is a checkpoint only node.
 * 
 * @param sig
 * @param remoteNNRole
 * @throws IOException
 */
void endCheckpoint(CheckpointSignature sig,
                   NamenodeRole remoteNNRole) throws IOException {
  sig.validateStorageInfo(this);
}
{code}

> NamenodeProtocol.endCheckpoint is vestigial and can be removed
> --------------------------------------------------------------
>
>                 Key: HDFS-2308
>                 URL: https://issues.apache.org/jira/browse/HDFS-2308
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>    Affects Versions: 0.24.0
>            Reporter: Aaron T. Myers
>            Assignee: Aaron T. Myers
>
> Post HDFS-1073, this method is now a no-op. All it does currently is validate the CheckpointSignature
provided, but does nothing to mutate NN state.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message