hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Jitendra Nath Pandey (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2188) HDFS-1580: Make FSEditLog create its journals from a list of URIs rather than NNStorage
Date Fri, 30 Sep 2011 07:04:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2188?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13117928#comment-13117928
] 

Jitendra Nath Pandey commented on HDFS-2188:
--------------------------------------------

  We could leave the old FSEditLog constructor and let it construct a new Configuration object
and call the new constructor. That way tests with existing constructor call will continue
to work. Do you see a problem in not removing the old constructor? If we don't want it to
be used anywhere we could add annotation to it @VisibleForTesting. 

Should we also change FileJournalManager constructor to take uri, instead of storage directory?
The method getStorageDirectory in NNStorage, should be called only for uri's representing
a file. 

What do you think of following? 
  Pass NNStorage and URI to FileJournalManager. FileJournalManager stores NNStorage and attemptRestoreRemovedStorage
is managed by FileJournalManager. This way FSEditLog can be made completely agnostic of storage
type. 

I don't mean to say that we should do all of the above in this jira only.


                
> HDFS-1580: Make FSEditLog create its journals from a list of URIs rather than NNStorage
> ---------------------------------------------------------------------------------------
>
>                 Key: HDFS-2188
>                 URL: https://issues.apache.org/jira/browse/HDFS-2188
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2188.diff, HDFS-2188.diff, HDFS-2188.diff, HDFS-2188.diff
>
>
> Currently, FSEditLog retrieves the list of Journals to create from NNStorage. Obviously
this is file specific. This JIRA aims to remove this restriction to make it possible to create
journals of custom types.

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message