hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Uma Maheswara Rao G (Commented) (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-497) One of the DFSClient::create functions ignores parameter
Date Tue, 27 Sep 2011 16:57:45 GMT

    [ https://issues.apache.org/jira/browse/HDFS-497?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13115705#comment-13115705
] 

Uma Maheswara Rao G commented on HDFS-497:
------------------------------------------

Hi Bill,

Are you talking about below code snippet in DFSClient?
{code}
public OutputStream create(String src, boolean overwrite) 
      throws IOException {
    return create(src, overwrite, dfsClientConf.defaultReplication,
        dfsClientConf.defaultBlockSize, null);
  }

{code}

{quote}
This can be fixed by simply passing the correct argument.{quote}

Here actually, when client doesn't want to see any progress, then why we need to pass progressible?

See the javadoc of Progressable

{code}
 * <p>Clients and/or applications can use the provided <code>Progressable</code>
 * to explicitly report progress to the Hadoop framework. This is especially
 * important for operations which take an insignificant amount of time since,
 * in-lieu of the reported progress, the framework has to assume that an error
 * has occured and time-out the operation.</p>{code}

in my opinion, when client invokes create api without progressable perameter, then we need
to pass it as null. I feel this is correct behavior. Please correct me if i understood wrongly.


Thanks
Uma


                
> One of the DFSClient::create functions ignores parameter
> --------------------------------------------------------
>
>                 Key: HDFS-497
>                 URL: https://issues.apache.org/jira/browse/HDFS-497
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: hdfs client
>    Affects Versions: 0.20.1
>            Reporter: Bill Zeller
>            Priority: Minor
>              Labels: newbie
>
> DFSClient::create(String src, boolean overwrite, Progressable progress) ignores progress
parameter

--
This message is automatically generated by JIRA.
If you think it was sent incorrectly, please contact your JIRA administrators: https://issues.apache.org/jira/secure/ContactAdministrators!default.jspa
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message