hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Kelly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2334) Add Closeable to JournalManager
Date Wed, 14 Sep 2011 16:35:10 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2334?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13104639#comment-13104639
] 

Ivan Kelly commented on HDFS-2334:
----------------------------------

findbugs are unrelated, see HDFS-2333

Failed tests have been failing for about a week at this stage.

This patch has added no new tests as the close methods on current JournalManagers are empty
at the moment. HDFS-234 will add a JournalManager which makes use of it, along with tests
for this new JournalManager.

> Add Closeable to JournalManager
> -------------------------------
>
>                 Key: HDFS-2334
>                 URL: https://issues.apache.org/jira/browse/HDFS-2334
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2334.diff
>
>
> A JournalManager may take hold of resources for the duration of their lifetime. This
isn't the case at the moment for FileJournalManager, but BookKeeperJournalManager will, and
it's conceivable that FileJournalManager could take a lock on a directory etc. 
> This JIRA is to add Closeable to JournalManager so that these resources can be cleaned
up when FSEditLog is closed.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message