Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id D02118B8B for ; Wed, 24 Aug 2011 18:00:53 +0000 (UTC) Received: (qmail 86469 invoked by uid 500); 24 Aug 2011 18:00:53 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 86404 invoked by uid 500); 24 Aug 2011 18:00:52 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 86396 invoked by uid 99); 24 Aug 2011 18:00:52 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2011 18:00:52 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 24 Aug 2011 18:00:51 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 17479CD387 for ; Wed, 24 Aug 2011 18:00:31 +0000 (UTC) Date: Wed, 24 Aug 2011 18:00:31 +0000 (UTC) From: "Uma Maheswara Rao G (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <803798785.10074.1314208831092.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-362) FSEditLog should not writes long and short as UTF8 and should not use ArrayWritable for writing non-array items MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: quoted-printable X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-362?page=3Dcom.atlassian.j= ira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=3D130903= 74#comment-13090374 ]=20 Uma Maheswara Rao G commented on HDFS-362: ------------------------------------------ Hi Todd, Thanks a lot for taking a look on this patch! {quote} Rather than comparing the logVersion variable against the numeric -39 versi= on, check out LayoutVersion.supports(...) =E2=80=93 makes the code easier t= o read {quote} Nice suggestion. Addressed in this patch. Thanks Uma > FSEditLog should not writes long and short as UTF8 and should not use Arr= ayWritable for writing non-array items > -------------------------------------------------------------------------= -------------------------------------- > > Key: HDFS-362 > URL: https://issues.apache.org/jira/browse/HDFS-362 > Project: Hadoop HDFS > Issue Type: Improvement > Components: name-node > Reporter: Tsz Wo (Nicholas), SZE > Assignee: Uma Maheswara Rao G > Attachments: HDFS-362.1.patch, HDFS-362.2.patch, HDFS-362.2b.patc= h, HDFS-362.2c.patch, HDFS-362.patch > > > In FSEditLog,=20 > - long and short are first converted to String and are further converted = to UTF8 > - For some non-array items, it first create an ArrayWritable object to ho= ld all the items and then writes the ArrayWritable object. > These result creating many intermediate objects which affects Namenode CP= U performance and Namenode restart. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira