Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 8 Aug 2011 12:42:27 +0000 (UTC)
From: "Uma Maheswara Rao G (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <2097837747.16444.1312807347263.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <1700666797.16270.1312800627242.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Updated] (HDFS-2238) NamenodeFsck.toString() uses
 StringBuilder with + operator
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


     [ https://issues.apache.org/jira/browse/HDFS-2238?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel ]

Uma Maheswara Rao G updated HDFS-2238:
--------------------------------------

    Status: Patch Available  (was: Open)

Verified all the fsck related tests, All are passing. No impact because of this change.

output format:

Status: CORRUPT
 Total size:	62523 B
 Total dirs:	17
 Total files:	20
 Total blocks (validated):	20 (avg. block size 3126 B)
  ********************************
  CORRUPT FILES:	20
  MISSING BLOCKS:	20
  MISSING SIZE:		62523 B
  CORRUPT BLOCKS: 	20
  ********************************
 Minimally replicated blocks:	0 (0.0 %)
 Over-replicated blocks:	0 (0.0 %)
 Under-replicated blocks:	0 (0.0 %)
 Mis-replicated blocks:		0 (0.0 %)
 Default replication factor:	0
 Average block replication:	0.0
 Corrupt blocks:		20
 Missing replicas:		0


No separate tests provided for this change.

> NamenodeFsck.toString() uses StringBuilder with + operator 
> -----------------------------------------------------------
>
>                 Key: HDFS-2238
>                 URL: https://issues.apache.org/jira/browse/HDFS-2238
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Uma Maheswara Rao G
>            Priority: Minor
>         Attachments: HDFS-2238.patch
>
>
> We should always use StringBuilder.append(..) but not + (string concatenation).

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira