Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 2135F8EB6 for ; Wed, 10 Aug 2011 19:12:52 +0000 (UTC) Received: (qmail 69336 invoked by uid 500); 10 Aug 2011 19:12:51 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 69301 invoked by uid 500); 10 Aug 2011 19:12:51 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 69279 invoked by uid 99); 10 Aug 2011 19:12:51 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2011 19:12:51 +0000 X-ASF-Spam-Status: No, hits=-2000.8 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2011 19:12:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 687D2B659B for ; Wed, 10 Aug 2011 19:12:27 +0000 (UTC) Date: Wed, 10 Aug 2011 19:12:27 +0000 (UTC) From: "Hadoop QA (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1910546411.24890.1313003547424.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <706327759.2668.1309926736917.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2129) Simplify BlockReader to not inherit from FSInputChecker MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-2129?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082575#comment-13082575 ] Hadoop QA commented on HDFS-2129: --------------------------------- -1 overall. Here are the results of testing the latest attachment http://issues.apache.org/jira/secure/attachment/12489510/seq-read-1gb-bench.png against trunk revision 1155998. +1 @author. The patch does not contain any @author tags. -1 tests included. The patch doesn't appear to include any new or modified tests. Please justify why no new tests are needed for this patch. Also please list what manual steps were performed to verify this patch. -1 patch. The patch command could not apply the patch. Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1067//console This message is automatically generated. > Simplify BlockReader to not inherit from FSInputChecker > ------------------------------------------------------- > > Key: HDFS-2129 > URL: https://issues.apache.org/jira/browse/HDFS-2129 > Project: Hadoop HDFS > Issue Type: Sub-task > Components: hdfs client > Reporter: Todd Lipcon > Assignee: Todd Lipcon > Fix For: 0.23.0 > > Attachments: hdfs-2129-benchmark.png, hdfs-2129.txt, hdfs-2129.txt, seq-read-1gb-bench.png > > > BlockReader is currently quite complicated since it has to conform to the FSInputChecker inheritance structure. It would be much simpler to implement it standalone. Benchmarking indicates it's slightly faster, as well. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira