Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Mon, 22 Aug 2011 11:53:30 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1264664772.826.1314014010090.JavaMail.tomcat@hel.zones.apache.org>
In-Reply-To: 
 <872274667.52036.1313730867163.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-2273) Refactor
 BlockManager.recentInvalidateSets to a new class
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-2273?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13088627#comment-13088627 ] 

Hadoop QA commented on HDFS-2273:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12491073/h2273_20110820.patch
  against trunk revision .

    +1 @author.  The patch does not contain any @author tags.

    -1 tests included.  The patch doesn't appear to include any new or modified tests.
                        Please justify why no new tests are needed for this patch.
                        Also please list what manual steps were performed to verify this patch.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:


    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1141//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1141//artifact/trunk/target/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1141//console

This message is automatically generated.

> Refactor BlockManager.recentInvalidateSets to a new class
> ---------------------------------------------------------
>
>                 Key: HDFS-2273
>                 URL: https://issues.apache.org/jira/browse/HDFS-2273
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>            Priority: Minor
>         Attachments: h2273_20110818.patch, h2273_20110818b.patch, h2273_20110820.patch
>
>
> recentInvalidateSets and the associated methods can be moved out from BlockManager.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira