Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 02738894B for ; Tue, 30 Aug 2011 07:27:15 +0000 (UTC) Received: (qmail 35450 invoked by uid 500); 30 Aug 2011 07:27:13 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 35262 invoked by uid 500); 30 Aug 2011 07:27:02 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 35234 invoked by uid 99); 30 Aug 2011 07:27:00 -0000 Received: from athena.apache.org (HELO athena.apache.org) (140.211.11.136) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2011 07:27:00 +0000 X-ASF-Spam-Status: No, hits=-2000.5 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Tue, 30 Aug 2011 07:26:58 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 41538D60EC for ; Tue, 30 Aug 2011 07:26:38 +0000 (UTC) Date: Tue, 30 Aug 2011 07:26:38 +0000 (UTC) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1252481045.6395.1314689198264.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-962) Make DFSOutputStream MAX_PACKETS configurable MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 [ https://issues.apache.org/jira/browse/HDFS-962?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13093504#comment-13093504 ] Tsz Wo (Nicholas), SZE commented on HDFS-962: --------------------------------------------- Hi Justin, Thanks for working on this. Some comments on the patch: - change dfsMaxPackets to private and non-static. - define constants for dfs.max.packets in DFSConfigKeys > Make DFSOutputStream MAX_PACKETS configurable > --------------------------------------------- > > Key: HDFS-962 > URL: https://issues.apache.org/jira/browse/HDFS-962 > Project: Hadoop HDFS > Issue Type: Improvement > Components: hdfs client > Affects Versions: 0.22.0 > Reporter: Todd Lipcon > Assignee: Justin Joseph > Priority: Minor > Attachments: HDFS-962.patch > > > HDFS-959 suggests that the MAX_PACKETS variable (which determines how many outstanding data packets the DFSOutputStream will permit) may have an impact on performance. If so, we should make it configurable to trade off between memory and performance. I think it ought to be a secret/undocumented config for now - this will make it easier to benchmark without confusing users. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira