Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm
Precedence: bulk
Reply-To: hdfs-issues@hadoop.apache.org
Date: Wed, 10 Aug 2011 19:36:35 +0000 (UTC)
From: "Hadoop QA (JIRA)" <jira@apache.org>
To: hdfs-issues@hadoop.apache.org
Message-ID: 
 <1215028339.25012.1313004995913.JavaMail.tomcat@hel.zones.apache.org>
Subject: [jira] [Commented] (HDFS-362) FSEditLog should not writes long and
 short as UTF8 and should not use ArrayWritable for writing non-array items
MIME-Version: 1.0
Content-Type: text/plain; charset=utf-8
Content-Transfer-Encoding: 7bit


    [ https://issues.apache.org/jira/browse/HDFS-362?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082601#comment-13082601 ] 

Hadoop QA commented on HDFS-362:
--------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12489975/HDFS-362.1.patch
  against trunk revision 1155998.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 3 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    -1 javac.  The patch appears to cause tar ant target to fail.

    -1 findbugs.  The patch appears to cause Findbugs (version 1.3.9) to fail.

    +1 release audit.  The applied patch does not increase the total number of release audit warnings.

    -1 core tests.  The patch failed these core unit tests:


    -1 contrib tests.  The patch failed contrib unit tests.

    -1 system test framework.  The patch failed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1069//testReport/
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1069//console

This message is automatically generated.

> FSEditLog should not writes long and short as UTF8 and should not use ArrayWritable for writing non-array items
> ---------------------------------------------------------------------------------------------------------------
>
>                 Key: HDFS-362
>                 URL: https://issues.apache.org/jira/browse/HDFS-362
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Uma Maheswara Rao G
>         Attachments: HDFS-362.1.patch, HDFS-362.patch
>
>
> In FSEditLog, 
> - long and short are first converted to String and are further converted to UTF8
> - For some non-array items, it first create an ArrayWritable object to hold all the items and then writes the ArrayWritable object.
> These result creating many intermediate objects which affects Namenode CPU performance and Namenode restart.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira