Return-Path: X-Original-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Delivered-To: apmail-hadoop-hdfs-issues-archive@minotaur.apache.org Received: from mail.apache.org (hermes.apache.org [140.211.11.3]) by minotaur.apache.org (Postfix) with SMTP id 49DBD8951 for ; Wed, 10 Aug 2011 06:30:09 +0000 (UTC) Received: (qmail 85129 invoked by uid 500); 10 Aug 2011 06:30:06 -0000 Delivered-To: apmail-hadoop-hdfs-issues-archive@hadoop.apache.org Received: (qmail 84560 invoked by uid 500); 10 Aug 2011 06:29:57 -0000 Mailing-List: contact hdfs-issues-help@hadoop.apache.org; run by ezmlm Precedence: bulk List-Help: List-Unsubscribe: List-Post: List-Id: Reply-To: hdfs-issues@hadoop.apache.org Delivered-To: mailing list hdfs-issues@hadoop.apache.org Received: (qmail 84531 invoked by uid 99); 10 Aug 2011 06:29:52 -0000 Received: from nike.apache.org (HELO nike.apache.org) (192.87.106.230) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2011 06:29:52 +0000 X-ASF-Spam-Status: No, hits=-2000.8 required=5.0 tests=ALL_TRUSTED,RP_MATCHES_RCVD X-Spam-Check-By: apache.org Received: from [140.211.11.116] (HELO hel.zones.apache.org) (140.211.11.116) by apache.org (qpsmtpd/0.29) with ESMTP; Wed, 10 Aug 2011 06:29:48 +0000 Received: from hel.zones.apache.org (hel.zones.apache.org [140.211.11.116]) by hel.zones.apache.org (Postfix) with ESMTP id 35E62B529E for ; Wed, 10 Aug 2011 06:29:27 +0000 (UTC) Date: Wed, 10 Aug 2011 06:29:27 +0000 (UTC) From: "Tsz Wo (Nicholas), SZE (JIRA)" To: hdfs-issues@hadoop.apache.org Message-ID: <1209897687.23067.1312957767217.JavaMail.tomcat@hel.zones.apache.org> In-Reply-To: <464667367.21416.1312921467483.JavaMail.tomcat@hel.zones.apache.org> Subject: [jira] [Commented] (HDFS-2241) Remove implementing FSConstants interface just to access the constants defined in the interface MIME-Version: 1.0 Content-Type: text/plain; charset=utf-8 Content-Transfer-Encoding: 7bit X-JIRA-FingerPrint: 30527f35849b9dde25b450d4833f0394 X-Virus-Checked: Checked by ClamAV on apache.org [ https://issues.apache.org/jira/browse/HDFS-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082174#comment-13082174 ] Tsz Wo (Nicholas), SZE commented on HDFS-2241: ---------------------------------------------- +1 patch looks good. > Remove implementing FSConstants interface just to access the constants defined in the interface > ----------------------------------------------------------------------------------------------- > > Key: HDFS-2241 > URL: https://issues.apache.org/jira/browse/HDFS-2241 > Project: Hadoop HDFS > Issue Type: Improvement > Reporter: Suresh Srinivas > Assignee: Suresh Srinivas > Fix For: 0.23.0 > > Attachments: HDFS-2241.1.patch, HDFS-2241.patch > > > Currently many classes implement FSConstants.java interface just for the convenience of accessing the constants defined in it. This could be done by using static imports or in some cases using FSConstants., with no need for implementing the interface. -- This message is automatically generated by JIRA. For more information on JIRA, see: http://www.atlassian.com/software/jira