hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Eli Collins (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2117) DiskChecker#mkdirsWithExistsAndPermissionCheck may return true even when the dir is not created
Date Tue, 02 Aug 2011 00:08:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2117?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13075972#comment-13075972
] 

Eli Collins commented on HDFS-2117:
-----------------------------------

Are you referring to throwing an exception here instead of returning false? Given the rest
of the method returns true/false I think we should be consistent. I do think it's also reasonable
to replace the entire function and it's caller(s) with the code from trunk, however that seems
like it can be done separately. Presumably Arun generated different patches for 20/trunk for
a reason, though I haven't looked closely.  

> DiskChecker#mkdirsWithExistsAndPermissionCheck may return true even when the dir is not
created
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2117
>                 URL: https://issues.apache.org/jira/browse/HDFS-2117
>             Project: Hadoop HDFS
>          Issue Type: Bug
>          Components: data-node
>    Affects Versions: 0.20.203.1
>            Reporter: Eli Collins
>            Assignee: Eli Collins
>            Priority: Minor
>             Fix For: 0.20.205.0
>
>         Attachments: hdfs-2117-1.patch
>
>
> In branch-0.20-security as part of HADOOP-6566, DiskChecker#mkdirsWithExistsAndPermissionCheck
will return true even if it wasn't able to create the directory, which means instead of throwing
a DiskErrorException the code will proceed to getFileStatus and throw a FNF exception. Post
HADOOP-7040, which modified makeInstance to catch not just DiskErrorExceptions but IOExceptions
as well, this is not an issue since now the exception is caught either way. But for future
modifications we should still modify this method to return false if it was unable to create
the directory. This code is totally different in trunk, so not an issue there.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message