hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2108) Move datanode heartbeat handling to BlockManager
Date Tue, 02 Aug 2011 20:18:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2108?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13078411#comment-13078411
] 

Suresh Srinivas commented on HDFS-2108:
---------------------------------------

Comments:
# Please add class javadoc to HeartbeatManager. Also add comment (similar to Stats) on how
datanodes is synchronized
# Why have heartbeatManager in BlockManager. Why not just DatanodeManager to removeDataNode,
stop and start decommission etc.?
# HeartbeatManager#size(), a better method name is getLiveDataNodeCount()?
# Prefer adding getStats to HeartBeatManager instead of how it is done in FSNamesystem.java
that synchronizes on the HeartbeatManager.


> Move datanode heartbeat handling to BlockManager
> ------------------------------------------------
>
>                 Key: HDFS-2108
>                 URL: https://issues.apache.org/jira/browse/HDFS-2108
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h2108_20110727.patch, h2108_20110727b.patch, h2108_20110801.patch
>
>
> Logically, datanodes should heartbeat to block manager instead of name system.  Therefore,
we should move datanode heartbeat handling code to {{BlockManager}}.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message