hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Hadoop QA (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2241) Remove implementing FSConstants interface just to access the constants defined in the interface
Date Wed, 10 Aug 2011 22:17:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13082714#comment-13082714
] 

Hadoop QA commented on HDFS-2241:
---------------------------------

-1 overall.  Here are the results of testing the latest attachment 
  http://issues.apache.org/jira/secure/attachment/12490033/HDFS-2241.2.patch
  against trunk revision 1155998.

    +1 @author.  The patch does not contain any @author tags.

    +1 tests included.  The patch appears to include 15 new or modified tests.

    +1 javadoc.  The javadoc tool did not generate any warning messages.

    +1 javac.  The applied patch does not increase the total number of javac compiler warnings.

    +1 findbugs.  The patch does not introduce any new Findbugs (version 1.3.9) warnings.

    +1 release audit.  The applied patch does not increase the total number of release audit
warnings.

    -1 core tests.  The patch failed these core unit tests:
                  org.apache.hadoop.hdfs.server.blockmanagement.TestReplicationPolicy
                  org.apache.hadoop.hdfs.server.namenode.TestCheckpoint
                  org.apache.hadoop.hdfs.server.namenode.TestNNThroughputBenchmark
                  org.apache.hadoop.hdfs.server.namenode.TestValidateConfigurationSettings
                  org.apache.hadoop.hdfs.TestHDFSServerPorts

    +1 contrib tests.  The patch passed contrib unit tests.

    +1 system test framework.  The patch passed system test framework compile.

Test results: https://builds.apache.org/job/PreCommit-HDFS-Build/1078//testReport/
Findbugs warnings: https://builds.apache.org/job/PreCommit-HDFS-Build/1078//artifact/trunk/build/test/findbugs/newPatchFindbugsWarnings.html
Console output: https://builds.apache.org/job/PreCommit-HDFS-Build/1078//console

This message is automatically generated.

> Remove implementing FSConstants interface just to access the constants defined in the
interface
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2241
>                 URL: https://issues.apache.org/jira/browse/HDFS-2241
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2241.1.patch, HDFS-2241.2.patch, HDFS-2241.patch
>
>
> Currently many classes implement FSConstants.java interface just for the convenience
of accessing the constants defined in it. This could be done by using static imports or in
some cases using FSConstants.<CONSTANT_NAME>, with no need for implementing the interface.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message