hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Updated] (HDFS-2241) Remove implementing FSConstants interface just to access the constants defined in the interface
Date Wed, 10 Aug 2011 05:59:27 GMT

     [ https://issues.apache.org/jira/browse/HDFS-2241?page=com.atlassian.jira.plugin.system.issuetabpanels:all-tabpanel
]

Suresh Srinivas updated HDFS-2241:
----------------------------------

    Attachment: HDFS-2241.1.patch

bq. Do you know why the following code does not use the defaults in DFSConfigKeys?
I changed them to use default constants.

bq. Define a conf key for "io.file.buffer.size"
This is already in CommonConfigurationKeysPublic. Will do it in a separate jira, as there
are many instances of this. I did a few in this jira.

bq. rename SIZE_OF_INTEGER to NUM_BYTES_OF_INTEGER in FSConstants.
Changed to BYTES_IN_INTEGER

bq. Move everything in FSConstants to HdfsConstatns. (BTW, we also has another FsConstants
in common; see HDFS-1620.)
Will do this in another jira


> Remove implementing FSConstants interface just to access the constants defined in the
interface
> -----------------------------------------------------------------------------------------------
>
>                 Key: HDFS-2241
>                 URL: https://issues.apache.org/jira/browse/HDFS-2241
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Suresh Srinivas
>            Assignee: Suresh Srinivas
>             Fix For: 0.23.0
>
>         Attachments: HDFS-2241.1.patch, HDFS-2241.patch
>
>
> Currently many classes implement FSConstants.java interface just for the convenience
of accessing the constants defined in it. This could be done by using static imports or in
some cases using FSConstants.<CONSTANT_NAME>, with no need for implementing the interface.

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message