hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Suresh Srinivas (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2239) Reduce access levels of the fields and methods in FSNamesystem
Date Tue, 09 Aug 2011 17:09:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2239?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13081769#comment-13081769
] 

Suresh Srinivas commented on HDFS-2239:
---------------------------------------

Comments:
# In order to keep the code simpler, please consider adding FSNamesystem#getDatanodeManager()
instead of cluster.getNamesystem().getBlockManager().getDatanodeManager(). 
# Even for upgrade manager now we have {{namesystem.getUpgradeManager().processUpgradeCommand(comm)}}.
I feel this kind of code exposes the internal structure and interfaces of internal components,
making future code changes hard. See http://en.wikipedia.org/wiki/Law_of_Demeter


> Reduce access levels of the fields and methods in FSNamesystem
> --------------------------------------------------------------
>
>                 Key: HDFS-2239
>                 URL: https://issues.apache.org/jira/browse/HDFS-2239
>             Project: Hadoop HDFS
>          Issue Type: Sub-task
>          Components: name-node
>            Reporter: Tsz Wo (Nicholas), SZE
>            Assignee: Tsz Wo (Nicholas), SZE
>         Attachments: h2239_20110808.patch, h2239_20110808b.patch
>
>


--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message