hadoop-hdfs-issues mailing list archives

Site index · List index
Message view « Date » · « Thread »
Top « Date » · « Thread »
From "Ivan Kelly (JIRA)" <j...@apache.org>
Subject [jira] [Commented] (HDFS-2187) HDFS-1580: Make EditLogInputStream act like an iterator over FSEditLogOps
Date Thu, 04 Aug 2011 16:25:27 GMT

    [ https://issues.apache.org/jira/browse/HDFS-2187?page=com.atlassian.jira.plugin.system.issuetabpanels:comment-tabpanel&focusedCommentId=13079448#comment-13079448
] 

Ivan Kelly commented on HDFS-2187:
----------------------------------

All look good except for the wrapper function for validateEditLog. I've no problem with the
idea of it, but it is file specific in a class that knows nothing else about files. It belongs
somewhere else, perhaps in the inspector, or maybe even on EditLogFileInputStream.

> HDFS-1580: Make EditLogInputStream act like an iterator over FSEditLogOps
> -------------------------------------------------------------------------
>
>                 Key: HDFS-2187
>                 URL: https://issues.apache.org/jira/browse/HDFS-2187
>             Project: Hadoop HDFS
>          Issue Type: Improvement
>            Reporter: Ivan Kelly
>            Assignee: Ivan Kelly
>             Fix For: 0.23.0
>
>         Attachments: 2187-changes.txt, HDFS-2187.diff, HDFS-2187.diff, hdfs-2187.txt
>
>
> This JIRA is for the input side changes moved out of HDFS-2149. EditLogInputStream has
been changed to no longer be an InputStream implementation, but to return a stream of FSEditLogOp
objects using readOp(). The upshot is that all that can ever be read from an EditLogInputStream
is a op. No random hackery can be used to put other things in the stream. Version is now a
property of the EditLogInputStream and retrieved using getVersion().

--
This message is automatically generated by JIRA.
For more information on JIRA, see: http://www.atlassian.com/software/jira

        

Mime
View raw message